use ClimaParams for shared parameters in coupled sims #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/climaparams
branch
5 times, most recently
from
05553da to
0f5c7bd
Compare
Member
Author
|
@costachris do you think this PR addresses #1491 or is there more work to be done for that? |
nefrathenrici
approved these changes
Nov 6, 2025
Member
nefrathenrici
left a comment
nefrathenrici
left a comment
There was a problem hiding this comment.
Thanks! This looks good, though I'm a bit confused by the planet radius units.
| return CA.AtmosConfig(atmos_config) | ||
|
|
||
| # Construct the AtmosConfig object | ||
| toml_dict = coupled_param_dict |
Member
There was a problem hiding this comment.
I'm a bit confused by this toml_dict redefinition, do we not want to use the existing toml_dict?
Member
Author
There was a problem hiding this comment.
Oops yes you are right
juliasloan25
force-pushed
the
js/climaparams
branch
from
0f5c7bd to
7ce3e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Get parameters from ClimaParams instead of hardcoding them in ClimaCoupler.
Note that any parameter overrides specified in
parameter_filesare now applied at the coupler level (in the driver), then passed to component models as a TOML dict. This might change interfaces for calibration and/or weather quest.closes #1520
closes #1372
might close #342 and #70, but we need to make sure these parameters aren't being overwritten in component models
Content
To Do
remaining:
atmos accepting a toml dict (maybe can just call AtmosConfig directly)
oceananigans/climaseaice accepting a toml dict of parameters
add tests to verify that components are using the same values